Subaru: driver torque sensor Nm scaling factor and unit #1198
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
|
jyoung8607
requested changes
Sep 6, 2024
There was a problem hiding this comment.
It's good to have known correct units for the driver input torque signal. However:
- You switched to a new signal; it's very important to reference the same signal in Panda safety
- Having re-scaled the signal, you also need to re-scale the driver input threshold in openpilot
- You will need corresponding scaling and driver input threshold updates to Panda
In short, this is the beginning of a valid change but needs additional work, including a companion Panda PR.
|
Thanks for the comments, I will set up panda safety PR |
|
I added the scaling factor and panda PR is at commaai/panda#2016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Nm unit for Subaru driver torque sensor signal for gen1 and gen2 and updates carstate to use new signal. Matched with SSM4 signal output by to jnewb1 at martinl/openpilot#80